Skip to content

fix: convolution test deadcode #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2025
Merged

fix: convolution test deadcode #177

merged 2 commits into from
Aug 23, 2025

Conversation

mizar
Copy link
Collaborator

@mizar mizar commented Aug 23, 2025 •
edited
Loading

This pull request makes a minor change to the test module in src/convolution.rs, specifically by removing an unused or unnecessary macro invocation. No functional changes to the code logic are introduced.

  • Removed the modulus!(M1, M2, M3); macro call from the test module in src/convolution.rs, likely because it was redundant or not needed.

ac-library-rs/src/convolution.rs

Line 539 in 032ef62

modulus!(M1, M2, M3);
and Rust 1.89 cause:

warning: enum `M1` is never used
   --> src/convolution.rs:539:18
    |
539 |         modulus!(M1, M2, M3);
    |                  ^^
    |
    = note: `#[warn(dead_code)]` on by default
    = note: this warning originates in the macro `modulus` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: enum `M2` is never used
   --> src/convolution.rs:539:22
    |
539 |         modulus!(M1, M2, M3);
    |                      ^^
    |
    = note: this warning originates in the macro `modulus` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: enum `M3` is never used
   --> src/convolution.rs:539:26
    |
539 |         modulus!(M1, M2, M3);
    |                          ^^
    |
    = note: this warning originates in the macro `modulus` (in Nightly builds, run with -Z macro-backtrace for more info)

@mizar mizar requested review from qryxip and Copilot August 23, 2025 08:46
Copilot

This comment was marked as outdated.

Sign in to view

@mizar mizar changed the title fix: fix: convolution test deadcode Aug 23, 2025
@mizar mizar requested a review from Copilot August 23, 2025 08:49
Copilot
Copilot AI reviewed Aug 23, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unused code in the convolution test module to eliminate dead code warnings. The change removes a macro invocation that was creating unused enum declarations.

  • Removes the modulus!(M1, M2, M3) macro call that was generating unused enum warnings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mizar mizar requested review from qryxip and removed request for qryxip August 23, 2025 08:55
@mizar mizar mentioned this pull request Aug 23, 2025
Merged
qryxip
qryxip approved these changes Aug 23, 2025
View reviewed changes
Copy link
Member

@qryxip qryxip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. This code seems to be dead ever since I wrote #45.

@mizar mizar merged commit 77d7849 into rust-lang-ja:master Aug 23, 2025
13 checks passed
@mizar mizar deleted the fix_convolution_test_deadcode branch August 23, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@qryxip qryxip qryxip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
AtCoder Language Update 2024-2025
Development

Successfully merging this pull request may close these issues.
2 participants
@mizar @qryxip